Quadtrees shapes #6681
Merged
Quadtrees shapes #6681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Missing Changelog
square now a subtype of rect, circle now a subtype of ellipse
Zonespace27
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Additional shapes available for testing against quadtrees or elsewhere: square, ellipse, circle. Square is a simplified version of the rectangle, circle is a simplified version of the ellipse.
Cleaned up existing code for shapes (rectangles), should be better documented and easier to read.
Where possible converted existing RECT usage to SQUARE (everything was squares anyway).
Where possible loosened defined types to the base
/datum/shapeso shape types can be swapped as desired.Explain why it's good for the game
Should (currently) have no effect on the game, but paves the way for more interesting uses for quadtrees. Circular areas of effect, for instance.
Testing Photographs and Procedure
Boots. Sentries, flamer sentries, bell towers, flags, sentry laptop, motion detector, and egg morpher all appear to work as intended.
Changelog
No player facing changes.